Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve golangci-lint coverage #549

Merged
merged 31 commits into from
Dec 10, 2024
Merged

Improve golangci-lint coverage #549

merged 31 commits into from
Dec 10, 2024

Conversation

simondeziel
Copy link
Member

Partly addresses #523.

@simondeziel
Makefile: drop unneeded Go version in go mod tidy
8e447ff 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
Align golangci-lint config with that of LXD
9852d08 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
golangci: disable exported and var-naming revive rules for now
9a7ad50 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance_snapshot: simplify if/else (revive)
29e4e06 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/common/lxd_interface: fix comment of exported structs
da816d1 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/utils: fix comment for DiffSlices
64b705f 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/common/lxd_exec: add comments for exported type/struct
fa4aa91 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/common/lxd_import: s/importId/importID/g
23782bb 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/network/resource_network_forward: add comment to exported st…
ea3a117 
…ruct

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/profile/resource_profile: add comment to exported struct
606fae6 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/storage/resource_storage_bucket_key: add comment to exported…
b2bbe76 
… struct

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/storage/resource_storage_pool: add comment to exported struct
b62e173 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/storage/resource_storage_volume_copy: add comment to exporte…
c7a8176 
…d struct

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/utils/buffer: add comments to exported funcs
52845a2 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/acctest/checks: ignore conn.Close() error
d56e40d 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/common/lxd_import: s/importId/importID/g
4eb2269 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/provider/provider: remove dup'ed import
8c66fd7 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance_file: use named returns in splitF…
71f1304 
…ileResourceID()

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance_file: don't access slice out of b…
6722c57 
…ound in splitFileResourceID()

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance_file: no need for fmt.Sprintf() i…
4f16d02 
…n createFileResourceID()

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance: avoid redefining new
44b8869 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/image/resource_publish_image: check if type cast was successful
0933074 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/provider-config/config: check if type casts were successful
ee3e210 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/provider/provider_test: ignore errors from os.Setenv/Unsetenv
5cb1658 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/image/resource_publish_image: name receiver
e9a1bd2 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/instance/resource_instance: name receiver
d6fd8fb 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/network/resource_network: name receiver
e4740b9 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/project/resource_project: name receiver
6811934 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/storage/resource_storage_bucket: name receiver
b6f5b7b 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
internal/storage/resource_storage_pool: name receiver
194e210 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
Copy link
Member Author

@MusicDin I fixed the low hanging fruit (with your help, thanks!) but ended up disabling the exported and var-naming rules from revive. Would you be willing to make them work? I feel like knowing the code base much better than I do means you are in a better position to do this.

@simondeziel simondeziel marked this pull request as ready for review December 10, 2024 21:35
@simondeziel simondeziel requested a review from MusicDin December 10, 2024 22:47
MusicDin
MusicDin reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@MusicDin MusicDin merged commit 8d770ac into terraform-lxd:main Dec 10, 2024
9 checks passed
@simondeziel simondeziel deleted the golangci-lint branch December 11, 2024 13:55
@MusicDin MusicDin added the chore label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusicDin MusicDin MusicDin approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @MusicDin